\label{doc_api_review_core_keyGetBaseName_md_md_doc_api_review_core_keyGetBaseName}%
\Hypertarget{doc_api_review_core_keyGetBaseName_md_md_doc_api_review_core_keyGetBaseName}%

\begin{DoxyItemize}
\item start = 2021-\/03-\/04 21\+:05
\item end = 2021-\/03-\/04 21\+:35
\item reviewer = Stefan Hanreich \href{mailto:stefanhani@gmail.com}{\texttt{ stefanhani@gmail.\+com}}
\end{DoxyItemize}\hypertarget{doc_api_review_core_keyGetBaseName_md_autotoc_md822}{}\doxysection{Signature}\label{doc_api_review_core_keyGetBaseName_md_autotoc_md822}
{\ttfamily ssize\+\_\+t \mbox{\hyperlink{group__keyname_ga0992d26bcfca767cb8e77053a483eb64}{key\+Get\+Base\+Name(const Key $\ast$key, char $\ast$returned, size\+\_\+t max\+Size)}}}\hypertarget{doc_api_review_core_keyGetBaseName_md_autotoc_md823}{}\doxysection{Checklist}\label{doc_api_review_core_keyGetBaseName_md_autotoc_md823}
\hypertarget{doc_api_review_core_keyGetBaseName_md_autotoc_md824}{}\doxysubsubsection{Doxygen}\label{doc_api_review_core_keyGetBaseName_md_autotoc_md824}
(bullet points are in order of appearance)


\begin{DoxyItemize}
\item \mbox{[}x\mbox{]} First line explains briefly what the function does
\item \mbox{[} \mbox{]} Simple example or snippet how to use the function ~\newline

\begin{DoxyItemize}
\item \mbox{[} \mbox{]} add
\end{DoxyItemize}
\item \mbox{[} \mbox{]} Longer description of function containing common use cases ~\newline

\begin{DoxyItemize}
\item \mbox{[} \mbox{]} add description of what happens when max\+Size $<$ base\+Name\+Size
\end{DoxyItemize}
\item \mbox{[}x\mbox{]} Description of functions reads nicely
\item \mbox{[} \mbox{]} {\ttfamily @pre} ~\newline

\begin{DoxyItemize}
\item \mbox{[} \mbox{]} add
\end{DoxyItemize}
\item \mbox{[} \mbox{]} {\ttfamily @post} ~\newline

\begin{DoxyItemize}
\item \mbox{[} \mbox{]} add
\end{DoxyItemize}
\item \mbox{[} \mbox{]} {\ttfamily @invariant} ~\newline

\begin{DoxyItemize}
\item \mbox{[} \mbox{]} add
\end{DoxyItemize}
\item \mbox{[}x\mbox{]} {\ttfamily @param} for every parameter
\item \mbox{[}x\mbox{]} {\ttfamily @return} / {\ttfamily @retval}
\item \mbox{[} \mbox{]} {\ttfamily @since} ~\newline

\begin{DoxyItemize}
\item \mbox{[} \mbox{]} add
\end{DoxyItemize}
\item \mbox{[}x\mbox{]} {\ttfamily @ingroup}
\item \mbox{[} \mbox{]} {\ttfamily @see} ~\newline

\begin{DoxyItemize}
\item \mbox{[} \mbox{]} split first line ~\newline

\item \mbox{[} \mbox{]} maybe remove second line?
\end{DoxyItemize}
\end{DoxyItemize}\hypertarget{doc_api_review_core_keyGetBaseName_md_autotoc_md825}{}\doxysubsection{Naming}\label{doc_api_review_core_keyGetBaseName_md_autotoc_md825}

\begin{DoxyItemize}
\item Abbreviations used in function names must be defined in the \mbox{\hyperlink{doc_help_elektra-glossary_md}{Glossary}}
\item \mbox{[}x\mbox{]} Function names should neither be too long, nor too short
\item \mbox{[}x\mbox{]} Function name should be clear and unambiguous
\item Abbreviations used in parameter names must be defined in the \mbox{\hyperlink{doc_help_elektra-glossary_md}{Glossary}}
\item \mbox{[}x\mbox{]} Parameter names should neither be too long, nor too short
\item \mbox{[} \mbox{]} Parameter names should be clear and unambiguous ~\newline

\begin{DoxyItemize}
\item \mbox{[} \mbox{]} change to returned\+Base\+Name in order to be more in line with other ~\newline
 functions?
\end{DoxyItemize}
\end{DoxyItemize}\hypertarget{doc_api_review_core_keyGetBaseName_md_autotoc_md826}{}\doxysubsection{Compatibility}\label{doc_api_review_core_keyGetBaseName_md_autotoc_md826}
(only in PRs)


\begin{DoxyItemize}
\item \mbox{\hyperlink{doc_dev_symbol-versioning_md}{Symbol versioning}} is correct for breaking changes
\item ABI/\+API changes are forward-\/compatible (breaking backwards-\/compatibility to add additional symbols is fine)
\end{DoxyItemize}\hypertarget{doc_api_review_core_keyGetBaseName_md_autotoc_md827}{}\doxysubsection{Parameter \& Return Types}\label{doc_api_review_core_keyGetBaseName_md_autotoc_md827}

\begin{DoxyItemize}
\item Function parameters should use enum types instead of boolean types wherever sensible
\item \mbox{[}x\mbox{]} Wherever possible, function parameters should be {\ttfamily const}
\item \mbox{[}x\mbox{]} Wherever possible, return types should be {\ttfamily const}
\item \mbox{[}x\mbox{]} Functions should have the least amount of parameters feasible
\end{DoxyItemize}\hypertarget{doc_api_review_core_keyGetBaseName_md_autotoc_md828}{}\doxysubsection{Structural Clarity}\label{doc_api_review_core_keyGetBaseName_md_autotoc_md828}

\begin{DoxyItemize}
\item \mbox{[}x\mbox{]} Functions should do exactly one thing
\item \mbox{[}x\mbox{]} Function name has the appropriate prefix
\item \mbox{[}x\mbox{]} Order of signatures in kdb.\+h.\+in is the same as Doxygen
\item \mbox{[}x\mbox{]} No functions with similar purpose exist
\end{DoxyItemize}\hypertarget{doc_api_review_core_keyGetBaseName_md_autotoc_md829}{}\doxysubsection{Memory Management}\label{doc_api_review_core_keyGetBaseName_md_autotoc_md829}

\begin{DoxyItemize}
\item \mbox{[}x\mbox{]} Memory Management should be handled by the function wherever possible
\end{DoxyItemize}\hypertarget{doc_api_review_core_keyGetBaseName_md_autotoc_md830}{}\doxysubsection{Extensibility}\label{doc_api_review_core_keyGetBaseName_md_autotoc_md830}

\begin{DoxyItemize}
\item \mbox{[}x\mbox{]} Function is easily extensible, e.\+g., with flags
\item \mbox{[}x\mbox{]} Documentation does not impose limits, that would hinder further extensions
\end{DoxyItemize}\hypertarget{doc_api_review_core_keyGetBaseName_md_autotoc_md831}{}\doxysubsection{Tests}\label{doc_api_review_core_keyGetBaseName_md_autotoc_md831}

\begin{DoxyItemize}
\item \mbox{[} \mbox{]} Function code is fully covered by tests ~\newline

\begin{DoxyItemize}
\item \mbox{[} \mbox{]} Lines 1147\+:1148
\end{DoxyItemize}
\item \mbox{[} \mbox{]} All possible error states are covered by tests ~\newline

\begin{DoxyItemize}
\item \mbox{[} \mbox{]} Lines 1147\+:1148
\end{DoxyItemize}
\item All possible enum values are covered by tests
\item \mbox{[}x\mbox{]} No inconsistencies between tests and documentation
\end{DoxyItemize}\hypertarget{doc_api_review_core_keyGetBaseName_md_autotoc_md832}{}\doxysection{Summary}\label{doc_api_review_core_keyGetBaseName_md_autotoc_md832}
add more tests for special cases? (spaces, escaped slashes,...)\hypertarget{doc_api_review_core_keyGetBaseName_md_autotoc_md833}{}\doxysection{Other Issues discovered (unrelated to function)}\label{doc_api_review_core_keyGetBaseName_md_autotoc_md833}
